fix(gui): add RTL support to delete-confirmation-prompt #236
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@pishi-ai, thanks for your help! I really appreciate the testing notes, too. |
|
@KManolov3, do you have time to review this? If not, let me know. |
|
This looks good! I think we should try to get it merged for one of the upcoming releases. |
|
Sorry for the bother, @pishi-ai, but could you merge from our It looks like something went wrong and prevented the normal build-and-test steps from running for this PR. I've adjusted our settings, so those steps should run if you make any changes to this PR. Merging from our |
pishi-ai
force-pushed
the
develop
branch
4 times, most recently
from
75ed706 to
a73bb61
Compare
pishi-ai
changed the title
This commit adds RTL (Right-to-Left) support for the delete-confirmation-prompt. In RTL languages, when multiple sprites are opened, the delete section of the confirmation prompt extended beyond the window boundary. This update fixes the layout so it displays correctly in RTL as well as LTR.
pishi-ai
changed the title
|
The failing tests don’t seem related to this change. Could a maintainer confirm? |
This commit adds RTL (Right-to-Left) support for the delete-confirmation-prompt. In RTL languages, when multiple sprites are opened, the delete section of the confirmation prompt extended beyond the window boundary. This update fixes the layout so it displays correctly in RTL as well as LTR.
This commit adds RTL (Right-to-Left) language support to the delete-confirmation-prompt component in scratch-gui.
Resolves
In RTL languages, when multiple sprites are opened, the confirmation prompt extends beyond the window boundary. This PR fixes that issue by properly handling RTL layout.
Proposed Changes
Reason for Changes
RTL language support is essential for accessibility and internationalization. Without proper handling, the confirmation prompt becomes unusable in RTL contexts. This update ensures consistent behavior and layout across both LTR and RTL languages.
Test Coverage